Add input_truncated metric to appsec.waf.requests telemetry
#4860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 3c3e080 | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-09-17 14:40:53 Comparing candidate commit 3c3e080 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:profiling - intern_all 1000 repeated strings
|
y9v
force-pushed
the
add-input-truncation-metric-to-waf-requests-telemetry
branch
2 times, most recently
from
a9da013 to
11aafca
Compare
y9v
force-pushed
the
add-input-truncation-metric-to-waf-requests-telemetry
branch
from
58480b6 to
e82ec4a
Compare
y9v
force-pushed
the
add-input-truncation-metric-to-waf-requests-telemetry
branch
from
0a94d8f to
86b9763
Compare
y9v
deleted the
add-input-truncation-metric-to-waf-requests-telemetry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
input_truncatedmetric toappsec.waf.requeststelemetry.Motivation:
This change is extracted to a separate PR from #4839, since it required changes to
libddwaf-rbgem.Change log entry
None. This change is internal.
Additional Notes:
Follow up for #4839
Related
libddwaf-rbPR: DataDog/libddwaf-rb#91This PR is in draft mode until changes to
libddwaf-rbare merged and released.How to test the change?
CI and manual testing.